Skip to content

i18n(zh-Hant): translate account authentication messages - #13012

Merged
tiensonqin merged 2 commits into
logseq:masterfrom
nrps9909:i18n/zh-hant-account-auth
Sep 30, 2026
Merged

tiensonqin merged 2 commits into
logseq:masterfrom
nrps9909:i18n/zh-hant-account-auth

Conversation

@nrps9909

@nrps9909 nrps9909 commented Aug 11, 2026 •

Copy link
Copy Markdown

Summary

  • Translate 30 missing Traditional Chinese account and authentication messages.
  • Cover sign-in, verification-code, credential-error, and password-policy flows.
  • Preserve the {1} placeholder and newline contracts while using Taiwan terminology.

This patch does not overlap with the 127 translation keys currently covered by #12962.

Validation

  • bb lang:format-dicts
  • bb lang:validate-translations
  • bb lang:missing zh-Hant
  • bb lang:pseudo zh-Hant
  • git diff --check

All dictionary, referenced-key, rich-translation, placeholder, and pseudo-translation checks pass.

AI assistance disclosure: Codex was used to identify missing zh-Hant keys, compare them with the English source, verify placeholders and dictionary structure, run the listed validation, and help draft this description. I reviewed the final translations and diff.


Devin Review

@tiensonqin tiensonqin added the :type/enhancement Enhancement to product. Does not affect the overall basic use. label Aug 11, 2026
@tiensonqin
tiensonqin force-pushed the i18n/zh-hant-account-auth branch from 11d9ac6 to 06f253d Compare August 11, 2026 09:42
@CLAassistant

CLAassistant commented Aug 11, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@tiensonqin
tiensonqin requested a lite review from Copilot August 11, 2026 09:42
@tiensonqin

Copy link
Copy Markdown
Contributor

@nrps9909 Please sign CLA first.

@tiensonqin tiensonqin added the awaiting-response Issue will be closed if a reply is not received label Aug 11, 2026

This comment was marked as resolved.

@nrps9909

Copy link
Copy Markdown
Author

Thanks! I’ve signed the CLA and updated all five account/auth strings to use consistent honorifics (“您/您的”). bb lang:format-dicts and bb lang:validate-translations both pass.

@nrps9909

Copy link
Copy Markdown
Author

Revalidated after synchronizing the branch with current master. Exact head 9a3429f keeps the PR merge diff limited to 30 additions in src/resources/dicts/zh-hant.edn. The canonical bb lang:format-dicts command reports every dictionary already formatted. bb lang:validate-translations passes key validity, referenced-key coverage, unused-key checks, rich rendering contracts, and English placeholder contracts. bb lang:lint-hardcoded --git-changed and git diff --check also pass. The PR remains open, mergeable, and review-required. AI assistance disclosure: Codex was used to compare the synchronized head with current master, run the repository i18n validation workflow, inspect the English and Simplified Chinese source entries, and draft this status note. I verified the cited results before posting.

@tiensonqin
tiensonqin force-pushed the i18n/zh-hant-account-auth branch from 9a3429f to 3785bec Compare September 30, 2026 15:21
@tiensonqin
tiensonqin merged commit 6a06a87 into logseq:master Sep 30, 2026
1 check was pending

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Devin Review: 1 flag

Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

devin-ai-integration Bot pushed a commit that referenced this pull request Oct 1, 2026
* i18n(zh-Hant): translate account authentication messages

* i18n(zh-Hant): use consistent honorifics in account copy
devin-ai-integration Bot pushed a commit that referenced this pull request Oct 8, 2026
* i18n(zh-Hant): translate account authentication messages

* i18n(zh-Hant): use consistent honorifics in account copy
devin-ai-integration Bot pushed a commit that referenced this pull request Oct 8, 2026
* i18n(zh-Hant): translate account authentication messages

* i18n(zh-Hant): use consistent honorifics in account copy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-response Issue will be closed if a reply is not received :type/enhancement Enhancement to product. Does not affect the overall basic use.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants