fix: Allow appenders to depend on not-yet-loaded appenders.#986
Merged
nomiddlename merged 1 commit intolog4js-node:masterfrom Feb 10, 2020
mvastola:fix-appender-load-order
Merged
fix: Allow appenders to depend on not-yet-loaded appenders.#986nomiddlename merged 1 commit intolog4js-node:masterfrom mvastola:fix-appender-load-order
nomiddlename merged 1 commit intolog4js-node:masterfrom
mvastola:fix-appender-load-order
Conversation
nomiddlename
requested changes
Jan 31, 2020
Collaborator
nomiddlename
left a comment
nomiddlename
left a comment
There was a problem hiding this comment.
Hi - thanks for doing this. Could you add a test that covers it though, please? Should be pretty simple to come up with some config that reproduces the problem.
Codecov Report
@@ Coverage Diff @@
## master #986 +/- ##
==========================================
+ Coverage 98.61% 98.63% +0.01%
==========================================
Files 25 25
Lines 1013 1022 +9
==========================================
+ Hits 999 1008 +9
Misses 14 14
Continue to review full report at Codecov.
|
Contributor
Author
|
@nomiddlename test is added (and passing). |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Ok. Now it should be good. |
Collaborator
|
Thanks for this - published to NPM in [email protected] |
Contributor
Author
|
@nomiddlename Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #746