Update Loading mechanism instruction #1#985
Merged
lamweili merged 2 commits intolog4js-node:masterfrom Mar 22, 2022
leonimurilo:patch-1
Merged
Update Loading mechanism instruction #1#985lamweili merged 2 commits intolog4js-node:masterfrom leonimurilo:patch-1
lamweili merged 2 commits intolog4js-node:masterfrom
leonimurilo:patch-1
Conversation
Update Loading mechanism instruction (number 1 in priority) to match the current behaviour of the library.
Collaborator
|
Hi, thanks for this - while I agree that the code does something slightly different to the docs, I don't think your version (or the original) one explains what it is doing which is checking for the appender in the bundled core library appenders. |
This was referenced Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Loading mechanism instruction (number 1 in priority) to match the current behaviour of the library.