feat: allow to change default way to parse callstack#914
Merged
nomiddlename merged 2 commits intolog4js-node:masterfrom Jul 9, 2019
Merged
feat: allow to change default way to parse callstack#914nomiddlename merged 2 commits intolog4js-node:masterfrom
nomiddlename merged 2 commits intolog4js-node:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #914 +/- ##
==========================================
+ Coverage 97.98% 97.99% +<.01%
==========================================
Files 25 25
Lines 995 997 +2
==========================================
+ Hits 975 977 +2
Misses 20 20
Continue to review full report at Codecov.
|
nomiddlename
approved these changes
Jul 9, 2019
Collaborator
nomiddlename
left a comment
nomiddlename
left a comment
There was a problem hiding this comment.
Thanks for this, especially for taking the time to write the documentation - makes my job a bit easier.
Collaborator
|
Published to npm in [email protected] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a function to the logger to edit the function parsing the callstack.
Use case example: Can be use when all the call to logger.log are made from a custom "debug" class (called from outside with debug.log, debug.warn, etc ... ), doing the interface between debuging an app and log4js, to allow more flexibility, and you want to use layout patern to show the fileName where the debug.x is called.
You can this way create a custom function parsing callStack and removing lines concerning your "debug" class, and then give it to the logger.