Docs for appender passing#904
Merged
nomiddlename merged 2 commits intomasterfrom Jun 25, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
=========================================
Coverage ? 97.98%
=========================================
Files ? 25
Lines ? 995
Branches ? 0
=========================================
Hits ? 975
Misses ? 20
Partials ? 0
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some documentation that nobody will ever read, so that I can say "did you read the docs?" when they raise issues.
@kaxelson if you could take a quick look to confirm that it matches up with your pull request that would be great. I'll merge it anyway, so as not to delay the release - we can always fix up errors in the docs later.