Skip to content

TS Configuration interface: add enableCallStack#897

Merged
nomiddlename merged 2 commits intolog4js-node:masterfrom
citrusjunoss:master
Jun 19, 2019
Merged

TS Configuration interface: add enableCallStack#897
nomiddlename merged 2 commits intolog4js-node:masterfrom
citrusjunoss:master

Conversation

@citrusjunoss
Copy link
Copy Markdown
Contributor

add to enableCallStack to Configuration Interface

add to enableCallStack to Configuration Interface
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 18, 2019

Codecov Report

Merging #897 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #897   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files          25       25           
  Lines         995      995           
=======================================
  Hits          975      975           
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa6e9f4...09d7b32. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@nomiddlename nomiddlename left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. If you could remove the top-level enableCallStack that would be great.

Comment thread types/log4js.d.ts Outdated
@nomiddlename nomiddlename added this to the 4.3.2 milestone Jun 19, 2019
@nomiddlename nomiddlename merged commit 8f8dfee into log4js-node:master Jun 19, 2019
@nomiddlename
Copy link
Copy Markdown
Collaborator

Published to NPM in version 4.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants