Fixes for node v12#870
Merged
nomiddlename merged 6 commits intomasterfrom May 5, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #870 +/- ##
=========================================
+ Coverage 97.86% 97.97% +0.1%
=========================================
Files 25 25
Lines 937 937
=========================================
+ Hits 917 918 +1
+ Misses 20 19 -1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #870 +/- ##
=========================================
+ Coverage 97.86% 97.97% +0.1%
=========================================
Files 25 25
Lines 937 937
=========================================
+ Hits 917 918 +1
+ Misses 20 19 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes needed to get the tests passing in node v12. Most tests fixed by new sandboxed-module version, which handles the fact that the
processglobal is a non-enumerable property of the global object in node v12. Other tests changed to be a bit more robust whenutil.formatchanges its output. Node 12 added to travis builds.