feat: support for isomorphic logging on browser#1374
Merged
lamweili merged 1 commit intolog4js-node:masterfrom Mar 7, 2023
Merged
feat: support for isomorphic logging on browser#1374lamweili merged 1 commit intolog4js-node:masterfrom
lamweili merged 1 commit intolog4js-node:masterfrom
Conversation
aellerton
force-pushed
the
master
branch
2 times, most recently
from
fa3794d to
6cc56e2
Compare
Contributor
|
Now you are missing some tests for the test coverage and you should be good to go! |
lamweili
reviewed
Mar 7, 2023
Certain modules do not exist in a browser environment. In that environment, file-based appenders are effectively disabled by this commit, without modifying the source directly.
This was
linked to
issues
Mar 7, 2023
This was referenced Mar 7, 2023
lamweili
added
enhancement
lamweili
changed the title
Author
|
Thank you! |
Contributor
I should thank you instead! 🤗 |
aellerton
changed the title
aellerton
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain modules do not exist in a browser environment, e.g. cluster, file/os/path, etc.
In that environment, file-based appenders are effectively disabled by this commit, without modifying the source directly.
The
clustering.jsfile is still required, but this commit essentially makes it a no-op, again without modifying the source directly.This addresses #968 and supersedes PR 1023 #1023