Skip to content

fix: tilde expansion for windows#1363

Merged
lamweili merged 2 commits intomasterfrom
fix/tilde-expansion
Feb 19, 2023
Merged

fix: tilde expansion for windows#1363
lamweili merged 2 commits intomasterfrom
fix/tilde-expansion

Conversation

@lamweili
Copy link
Copy Markdown
Contributor

@lamweili lamweili commented Feb 15, 2023

Fixes log4js-node/streamroller#164

  1. ~ in ~/ or ~\ will be expanded to os.homedir()
    (~ and ~filename unaffected as these are valid filenames)

Fixes https://github.com/log4js-node/log4js-node/security/code-scanning/1 (since 4.3.0)

@lamweili lamweili added the bug Something isn't working label Feb 15, 2023
@lamweili lamweili added this to the 6.8.0 milestone Feb 15, 2023
@lamweili lamweili force-pushed the fix/tilde-expansion branch 3 times, most recently from 24380ac to ee5b7a9 Compare February 15, 2023 15:35
Comment thread lib/logger.js Fixed
@lamweili lamweili force-pushed the fix/tilde-expansion branch 5 times, most recently from 996c2e5 to e603166 Compare February 19, 2023 18:01
@lamweili lamweili force-pushed the fix/tilde-expansion branch from e603166 to 243592b Compare February 19, 2023 18:04
@lamweili lamweili merged commit b4c75d5 into master Feb 19, 2023
@lamweili lamweili deleted the fix/tilde-expansion branch February 19, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tilde expansion doesn't properly support Windows

2 participants