Skip to content

feat issue #1341 (Layouts) : support a specifier on %m#1346

Merged
lamweili merged 5 commits intolog4js-node:masterfrom
Mumeii:feature/issue-1341
Dec 5, 2022
Merged

feat issue #1341 (Layouts) : support a specifier on %m#1346
lamweili merged 5 commits intolog4js-node:masterfrom
Mumeii:feature/issue-1341

Conversation

@Mumeii
Copy link
Copy Markdown
Contributor

@Mumeii Mumeii commented Nov 14, 2022

PR proposal to implement #1341

@lamweili lamweili added the enhancement New feature or request label Nov 28, 2022
@lamweili lamweili added this to the 6.7.2 milestone Nov 28, 2022
@lamweili
Copy link
Copy Markdown
Contributor

Hi there, thanks for this and sorry I haven't gotten the time.
It will be meant for the 6.7.2 or 6.8.0 release once I have taken a closer look at it.

Does this also resolve the #1340 that you have mentioned in #1341?

Copy link
Copy Markdown
Contributor

@lamweili lamweili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some misc changes and the PR is good to go. 🤗

Comment thread docs/layouts.md Outdated
Comment thread lib/layouts.js Outdated
Comment thread lib/layouts.js Outdated
Comment thread test/tap/layouts-test.js Outdated
Comment thread test/tap/layouts-test.js Outdated
Comment thread test/tap/layouts-test.js Outdated
Comment thread test/tap/layouts-test.js Outdated
Comment thread test/tap/layouts-test.js Outdated
Comment thread test/tap/layouts-test.js Outdated
@Mumeii Mumeii requested a review from lamweili December 3, 2022 21:50
Comment thread test/tap/layouts-test.js Outdated
@Mumeii Mumeii requested a review from lamweili December 5, 2022 11:02
@lamweili lamweili merged commit ee0f4e4 into log4js-node:master Dec 5, 2022
@lamweili lamweili linked an issue Dec 5, 2022 that may be closed by this pull request
@lamweili lamweili modified the milestone: 6.8.0 Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make PatternLayout's %m more versatile

2 participants