Fix connectlogger nolog function#1285
Merged
lamweili merged 2 commits intolog4js-node:masterfrom Jul 8, 2022
Merged
Conversation
Contributor
|
Hi, I don't understand how that fixes the issue. Also, please add tests. Thanks! |
Contributor
Author
|
I meant server response headers like nolog: (req, res) => {
return /(css|javascript|image|font|svg|png|jpe?g)/i.test(res.getHeader('content-type'));
} |
Contributor
|
Ok, can you add tests? |
Contributor
Author
|
Ok, Roger that |
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Author
Test coverage done. |
lamweili
force-pushed
the
fix-connectlogger-function
branch
from
25eacc9 to
e71e088
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1284.
The server headers are now avalaible in nolog function.