Skip to content

Run prettier and require it#1271

Merged
lamweili merged 4 commits intolog4js-node:masterfrom
ZachHaber:prettier
Jun 22, 2022
Merged

Run prettier and require it#1271
lamweili merged 4 commits intolog4js-node:masterfrom
ZachHaber:prettier

Conversation

@ZachHaber
Copy link
Copy Markdown
Contributor

@ZachHaber ZachHaber commented Jun 20, 2022

@peteriman, I ran prettier accross the entire project, and like the logfaces-http, it now is part of the pretest config.

@lamweili
Copy link
Copy Markdown
Contributor

lamweili commented Jun 20, 2022 •
edited
Loading

Hmm, it broke the Windows tests?

The created test files should have been deleted on test teardown I believe.

@ZachHaber
Copy link
Copy Markdown
Contributor Author

ZachHaber commented Jun 20, 2022

Hmm, it broke the Windows tests?

The created test files should have been deleted on test teardown I believe.

That one particular test file has been appearing on my computer every time I ran the test. Even on the previous branch I used. I never opened the configuration-validation-test, but it started appearing one day, and then it always appeared after every time I ran the test afterwards.

@ZachHaber
Copy link
Copy Markdown
Contributor Author

ZachHaber commented Jun 20, 2022

It looks like the windows node 16 test should work faster after we run an npm install or update locally to let the package-lock.json file update to version 2.

@ZachHaber
Copy link
Copy Markdown
Contributor Author

ZachHaber commented Jun 20, 2022

@peteriman, windows tests went through this time, there were a couple files missing on the .gitattributes that caused them to download with crlf line endings instead of lf like the editorconfig/prettier wants.

@lamweili lamweili force-pushed the prettier branch 2 times, most recently from 64bad65 to 68fcec4 Compare June 22, 2022 16:56
@lamweili
Copy link
Copy Markdown
Contributor

lamweili commented Jun 22, 2022 •
edited
Loading

I made some changes to the commits:

  • merged the two commits for .gitattributes together
  • added a commit (e378b59) to refactor eslint comments so prettier can fix properly
  • removed the commit that added test/tap/freeze-date-file-test to .gitignore as it is not part of prettier fixes

@lamweili lamweili added this to the 6.5.3 milestone Jun 22, 2022
@lamweili lamweili merged commit cb5e44e into log4js-node:master Jun 22, 2022
@ZachHaber ZachHaber deleted the prettier branch June 22, 2022 17:14
@lamweili lamweili mentioned this pull request Jun 22, 2022
Merged
@sync-by-unito sync-by-unito Bot mentioned this pull request Jul 7, 2022
Closed
@sync-by-unito sync-by-unito Bot mentioned this pull request Jul 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ZachHaber @lamweili