refactor: replace deprecated String.prototype.substr()#1223
Merged
lamweili merged 1 commit intolog4js-node:masterfrom Mar 28, 2022
CommanderRoot:refactor/rm-deprecated-substr
Merged
refactor: replace deprecated String.prototype.substr()#1223lamweili merged 1 commit intolog4js-node:masterfrom CommanderRoot:refactor/rm-deprecated-substr
lamweili merged 1 commit intolog4js-node:masterfrom
CommanderRoot:refactor/rm-deprecated-substr
Conversation
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated Signed-off-by: Tobias Speicher <[email protected]>
This was referenced Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated. While String.prototype.substring() isn't deprecated I replaced it with
slice()as well.slice()is generally a bit faster (and uses less bites as the name is shorter) and this way we don't have 2 functions which nearly do the same thing in the code..substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.