Conversation
appenders/multiprocess.js - Line 121 - debug('connection error', e);
appenders/multiprocess.js - Line 122 - canWrite = false;
appenders/multiprocess.js - Line 123 - emptyBuffer();
appenders/tcp-server.js - Line 19 - dataSoFar = events.pop(); appenders/tcp-server.js - Line 27 - dataSoFar = '';
(requires truthy value, used a noop function, but the function never gets called anyway)
appenders/index.js - Line 95 - }, /* istanbul ignore next */ () => {});
appenders/index.js - Line 78 - process.emitWarning(
appenders/index.js - Line 79 - `Appender ${appenderConfig.type} exports a shutdown function.`,
appenders/index.js - Line 80 - "DeprecationWarning", "log4js-node-DEP0002"
appenders/index.js - Line 81 - );
appenders/index.js - Line 82 - debug(`DEPRECATION: Appender ${appenderConfig.type} exports a shutdown function.`);
lamweili
force-pushed
the
update-test
branch
19 times, most recently
from
4d738c0 to
3b22a33
Compare
log4js.js - Line 83 - return recordingModule
log4js.js - Line 37 - if (!enabled) return;
lamweili
force-pushed
the
update-test
branch
2 times, most recently
from
55d4f2c to
b634b1a
Compare
appenders/multiFile.js - Line 25 - debug('ignore error on file shutdown: %s', err.message);
…affect the next test
(else path will never be taken)
appenders/multiFile.js - Line 17 - /* istanbul ignore else */
appenders/multiFile.js - Line 18 - if (timer && app) {
appenders/fileSync.js - Line 58 - throw new Error(`maxLogSize (${maxLogSize}) should be > 0`);
This was referenced Mar 9, 2022
This was referenced Mar 16, 2022
This was referenced Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Test Coverage (Part 1 of 3)