fix: %f{depth} filename separator#1061
Closed
crgmz wants to merge 1 commit intolog4js-node:masterfrom
Closed
Conversation
27b2ec3 to
6be872a
Compare
6268846 to
be7c6ba
Compare
Contributor
|
As explained in #1060, I am unable to replicate the issue to warrant this PR. There shouldn't be any need to hardcode the pattern
|
Contributor
|
This PR has been superseded by #1224. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the split parameter to capture both
\and/separators inside array, and then modified the join expression to account for the extra elements in the array. Also removed path import as it's not longer needed.Related to #1060