Access to 'category' field of logger objects in TS#1006
Merged
nomiddlename merged 1 commit intolog4js-node:masterfrom May 24, 2020
Merged
Access to 'category' field of logger objects in TS#1006nomiddlename merged 1 commit intolog4js-node:masterfrom
nomiddlename merged 1 commit intolog4js-node:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1006 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 25 25
Lines 1030 1030
=======================================
Hits 1016 1016
Misses 14 14 Continue to review full report at Codecov.
|
Collaborator
|
Thanks a lot for this PR. |
Collaborator
|
Fix published in [email protected] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes it can be useful to know the category of the logger.
The category can be read from pure JavaScript code but TypeScript code cannot read it as the field is not declared.
This change adds the field to the TypeScript declaration. The access to it is read-only as changing the category of logger probably makes no sense.