Skip to content

Donot create appender if not used#1002

Merged
nomiddlename merged 2 commits intolog4js-node:masterfrom
rnd-debug:donot-create-appender-if-not-used
May 24, 2020
Merged

Donot create appender if not used#1002
nomiddlename merged 2 commits intolog4js-node:masterfrom
rnd-debug:donot-create-appender-if-not-used

Conversation

@rnd-debug
Copy link
Copy Markdown
Contributor

Related to #1000 . The fix will check if an appender exists in a category before trying to create it.

@rnd-debug
Copy link
Copy Markdown
Contributor Author

rnd-debug commented May 3, 2020

Interesting: fails on test/tap/server-test.js (not modified by the commits) with :

✖ connect ECONNREFUSED 127.0.0.1:5678

Any idea why?

@nomiddlename nomiddlename added this to the 6.3.0 milestone May 24, 2020
@nomiddlename nomiddlename merged commit 4b0c6f4 into log4js-node:master May 24, 2020
@nomiddlename
Copy link
Copy Markdown
Collaborator

Fix published in [email protected] - the ECONNREFUSED error was due to the tcp-server appender not being started, it just listens for tcp messages and forwards them to other appenders so it does not need a category assigned. I hacked in a dodgy fix for it.

@rnd-debug rnd-debug deleted the donot-create-appender-if-not-used branch May 30, 2020 08:58
@rnd-debug
Copy link
Copy Markdown
Contributor Author

Thank you for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File appenders try to open files even though they do not exist in a category

2 participants