Short circuit sortedIndexBy methods for empty arrays #4496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
megawac
force-pushed
the
short-circuit-sorted-index
branch
from
8c65c32 to
9b659d8
Compare
Member
|
Thanks @megawac! You may also want to open this against the |
Contributor
Author
|
Sounds good |
jdalton
added
issue bankruptcy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case that involves building many smallish sorted arrays so I'm using
sortedIndexByas part of an insertion sort logic. As empty arrays are a common condition for me, I figured I should reach out and see if we could get them short circuited. Cheers.