fix: prototype pollution in several npm packages#4337
Merged
jdalton merged 1 commit intolodash:npm-packagesfrom Jun 24, 2019
Kirill89:fix/prototype-pollution-packages
Merged
fix: prototype pollution in several npm packages#4337jdalton merged 1 commit intolodash:npm-packagesfrom Kirill89:fix/prototype-pollution-packages
jdalton merged 1 commit intolodash:npm-packagesfrom
Kirill89:fix/prototype-pollution-packages
Conversation
Kirill89
commented
Jun 19, 2019
| newValue = toPlainObject(objValue); | ||
| } | ||
| else if (!isObject(objValue) || (srcIndex && isFunction(objValue))) { | ||
| else if (!isObject(objValue) || isFunction(objValue)) { |
Contributor
Author
There was a problem hiding this comment.
This is backport from new version https://github.com/snyk/lodash/blob/4.17.12-pre/lodash.js#L3668
Kirill89
commented
Jun 19, 2019
| newValue = toPlainObject(objValue); | ||
| } | ||
| else if (!isObject(objValue) || (srcIndex && isFunction(objValue))) { | ||
| else if (!isObject(objValue) || isFunction(objValue)) { |
Contributor
Author
There was a problem hiding this comment.
This is backport from new version https://github.com/snyk/lodash/blob/4.17.12-pre/lodash.js#L3668
Kirill89
commented
Jun 19, 2019
| * @returns {*} Returns the property value. | ||
| */ | ||
| function safeGet(object, key) { | ||
| if (key === 'constructor' && typeof object[key] === 'function') { |
Kirill89
commented
Jun 19, 2019
| function baseMergeDeep(object, source, key, srcIndex, mergeFunc, customizer, stack) { | ||
| var objValue = object[key], | ||
| srcValue = source[key], | ||
| var objValue = safeGet(object, key), |
Contributor
Author
There was a problem hiding this comment.
This is backport from new version: https://github.com/snyk/lodash/blob/4.17.12-pre/lodash.js#L3624
Member
|
Thank you @Kirill89! |
jdalton
added
issue bankruptcy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is fixing a Prototype Pollution vulnerability in:
You can see details about similar vulnerability here: https://snyk.io/vuln/SNYK-JS-LODASH-73638