Ensure clone methods clone expando properties of boolean, number, & string objects. [closes #2008]

jdalton · jdalton · commit 7b93dc9c3253 · 2016-02-16T21:27:03.000-08:00
diff --git a/lodash.js b/lodash.js
@@ -2318,9 +2318,10 @@
             return copySymbols(value, baseAssign(result, value));
           }
         } else {
-          return cloneableTags[tag]
-            ? initCloneByTag(value, tag, isDeep)
-            : (object ? value : {});
+          if (!cloneableTags[tag]) {
+            return object ? value : {};
+          }
+          result = initCloneByTag(value, tag, isDeep);
         }
       }
       // Check for circular references and return its corresponding clone.
diff --git a/test/test.js b/test/test.js
@@ -813,17 +813,20 @@
 
         try {
           var symObject = Object(symbol);
+
+          // Avoid symbol detection in Babel's `typeof` helper.
           symObject.constructor = Object;
+
           actual = [
-            Symbol ? lodashBizarro.clone(symObject) : {},
+            Symbol ? lodashBizarro.clone(symObject) : { 'constructor': Object },
             Symbol ? lodashBizarro.isEqual(symObject, Object(symbol)) : false,
             Symbol ? lodashBizarro.toString(symObject) : ''
           ];
         } catch (e) {
           actual = null;
         }
         label = message('_.clone`, `_.isEqual`, and `_.toString', 'Symbol');
-        assert.deepEqual(actual, [{}, false, ''], label);
+        assert.deepEqual(actual, [{ 'constructor': Object }, false, ''], label);
 
         try {
           var map = new lodashBizarro.memoize.Cache;
@@ -2632,6 +2635,24 @@
         assert.strictEqual(actual.lastIndex, 3);
       });
 
+      QUnit.test('`_.' + methodName + '` should clone expando properties', function(assert) {
+        assert.expect(1);
+
+        var values = lodashStable.map([true, false, 1, 'a'], function(value) {
+          var object = Object(value);
+          object.a = 1;
+          return object;
+        });
+
+        var expected = lodashStable.map(values, alwaysTrue);
+
+        var actual = lodashStable.map(values, function(value) {
+          return func(value).a === 1;
+        });
+
+        assert.deepEqual(actual, expected);
+      });
+
       QUnit.test('`_.' + methodName + '` should clone prototype objects', function(assert) {
         assert.expect(2);
 

Original file line number	Diff line number	Diff line change
`@@ -2318,9 +2318,10 @@`
`2318`	`2318`	`return copySymbols(value, baseAssign(result, value));`
`2319`	`2319`	`}`
`2320`	`2320`	`} else {`
`2321`		`- return cloneableTags[tag]`
`2322`		`- ? initCloneByTag(value, tag, isDeep)`
`2323`		`- : (object ? value : {});`
	`2321`	`+ if (!cloneableTags[tag]) {`
	`2322`	`+ return object ? value : {};`
	`2323`	`+ }`
	`2324`	`+ result = initCloneByTag(value, tag, isDeep);`
`2324`	`2325`	`}`
`2325`	`2326`	`}`
`2326`	`2327`	`// Check for circular references and return its corresponding clone.`