Merged
Conversation
ghost
force-pushed
the
464-sequence-page-handle-non-latest-version
branch
from
7ede760 to
cee00e6
Compare
ghost
mentioned this pull request
ghost
force-pushed
the
464-sequence-page-handle-non-latest-version
branch
4 times, most recently
from
9385ee1 to
f0c61ad
Compare
ghost
added
website
ghost
marked this pull request as ready for review
ghost
changed the title
fengelniederhammer
requested changes
Dec 5, 2023
website/src/components/SequenceDetailsPage/SequencesDataTable.astro
Outdated
Show resolved
Hide resolved
ghost
force-pushed
the
464-sequence-page-handle-non-latest-version
branch
from
95b8c47 to
a04de1b
Compare
ghost
force-pushed
the
464-sequence-page-handle-non-latest-version
branch
from
a04de1b to
e1215c4
Compare
website/src/components/SequenceDetailsPage/SequencesBanner.astro
Outdated
Show resolved
Hide resolved
website/src/components/SequenceDetailsPage/SequencesBanner.astro
Outdated
Show resolved
Hide resolved
website/src/components/SequenceDetailsPage/SequencesDataTable.astro
Outdated
Show resolved
Hide resolved
website/src/components/SequenceDetailsPage/SequencesDataTable.astro
Outdated
Show resolved
Hide resolved
fengelniederhammer
requested changes
Dec 6, 2023
Contributor
fengelniederhammer
left a comment
fengelniederhammer
left a comment
There was a problem hiding this comment.
Some details and codestyle, otherwise this looks good 👍
ghost
force-pushed
the
464-sequence-page-handle-non-latest-version
branch
8 times, most recently
from
e832aed to
9d13d63
Compare
ghost
mentioned this pull request
fengelniederhammer
requested changes
Dec 9, 2023
Contributor
fengelniederhammer
left a comment
fengelniederhammer
left a comment
There was a problem hiding this comment.
I think we should improve the sanity check there.
ghost
force-pushed
the
464-sequence-page-handle-non-latest-version
branch
from
ef1589a to
386c30b
Compare
fengelniederhammer
approved these changes
Dec 11, 2023
ghost
force-pushed
the
464-sequence-page-handle-non-latest-version
branch
from
386c30b to
18f2cdd
Compare
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ticket has a follow-up: #619
sequence entries with
isRevocation===trueare not imported into SILO yet, so that we cannot link to the latest version in that case.