Merged
Conversation
…x mp4 videos so they migrate successfully
redshiftzero
approved these changes
Aug 15, 2025
Contributor
redshiftzero
left a comment
There was a problem hiding this comment.
LGTM:
- In a test X account, make several posts that includes photos, videos, and animated gifs, including one post with multiple animated gifs.
- Try migrating them to Bluesky. It should all work without errors.
Noting that the multiple animated gif post become a single animated gif on Bluesky as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few issues:
image-sizemodule to get aspect ratios when migrating images. I've removed that dependency (yay one less dependency) and replaced it with a simple function that looks like dimensions for PNGs and JPGs.Test plan