add reusable workflow to update test durations #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silv-io
approved these changes
Sep 30, 2025
Member
silv-io
left a comment
silv-io
left a comment
There was a problem hiding this comment.
LGTM! Will merge right after the next release
Comment on lines
+85
to
+90
| REPO_PATH="${{ inputs.path }}" # 'localstack' or 'localstack-pro' | ||
| if [ "$REPO_PATH" = "localstack-pro" ]; then | ||
| WF_FILE=".github/workflows/aws_main.yml" | ||
| else | ||
| WF_FILE=".github/workflows/aws-main.yml" | ||
| fi |
Member
There was a problem hiding this comment.
Should get rid of this inconsistency and also just give the option to overwrite the workflow file. But I'll change that in a future iteration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Centralize and reuse the “update test durations” logic across repositories.
This moves the implementation into the
metarepo as a reusable workflow so it can be invoked from:localstack/localstack(Updating the test duration workflow localstack#13170), andlocalstack/localstack-pro(https://github.com/localstack/localstack-pro/pull/5297).This reduces duplication, keeps behavior consistent, and makes future maintenance/changes single-sourced.
Changes
.github/workflows/update-test-durations.ymlin meta.pytest-split-durations-<platform>-*artifacts into${{ inputs.outPath }}.UPLOAD_ARTIFACT, orCREATE_PRusingpeter-evans/create-pull-request.