Skip to content

Update test instructions for agents#131

Merged
carole-lavillonniere merged 1 commit intomainfrom
update-skills-claude
Mar 18, 2026
Merged

Update test instructions for agents#131
carole-lavillonniere merged 1 commit intomainfrom
update-skills-claude

Conversation

@carole-lavillonniere
Copy link
Copy Markdown
Collaborator

@carole-lavillonniere carole-lavillonniere commented Mar 18, 2026

A bug fix should always come with a new test.

@carole-lavillonniere carole-lavillonniere changed the title update instructions for agents Update test instructions for agents Mar 18, 2026
@carole-lavillonniere carole-lavillonniere marked this pull request as ready for review March 18, 2026 10:31
Copy link
Copy Markdown
Contributor

@anisaoshafi anisaoshafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛

@carole-lavillonniere carole-lavillonniere merged commit be57d23 into main Mar 18, 2026
6 of 7 checks passed
@carole-lavillonniere carole-lavillonniere deleted the update-skills-claude branch March 18, 2026 10:34
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 18, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: bcf8730c-132b-4c64-841e-8e8b58665ac6

📥 Commits

Reviewing files that changed from the base of the PR and between 28a13b7 and d494561.

📒 Files selected for processing (2)
  • .claude/skills/review-pr/SKILL.md
  • CLAUDE.md

📝 Walkthrough

Walkthrough

This PR adds testing guidelines for bug fixes across two documentation files, requiring integration tests that fail before the fix and pass after the fix is applied.

Changes

Cohort / File(s) Summary
Testing Guidelines Documentation
.claude/skills/review-pr/SKILL.md, CLAUDE.md
Added testing requirements for bug fixes, specifying that integration tests must be added that reproduce the bug (failing before fix, passing after).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • silv-io
  • anisaoshafi
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update test instructions for agents' accurately reflects the main changes: updating testing guidelines in SKILL.md and CLAUDE.md with new requirements for bug fixes and integration tests.
Description check ✅ Passed The description 'A bug fix should always come with a new test' is directly related to the changeset, which adds testing requirements for bug fixes in both documentation files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-skills-claude
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants