Skip to content

Fix npm update not fetching the latest package version#124

Merged
gtsiolis merged 1 commit intomainfrom
george/des-173
Mar 17, 2026
Merged

Fix npm update not fetching the latest package version#124
gtsiolis merged 1 commit intomainfrom
george/des-173

Conversation

@gtsiolis
Copy link
Copy Markdown
Member

@gtsiolis gtsiolis commented Mar 17, 2026

This will change to npm install @localstack/lstk@latest to force npm to always resolve the newest published version. previously, lstk update via npm ran npm install @localstack/lstk which could be a no-op if npm considered the installed version satisfactory.

Fix DES-173

@gtsiolis gtsiolis self-assigned this Mar 17, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 58dddf13-349f-4c9a-a077-f3e86f1c6ea1

📥 Commits

Reviewing files that changed from the base of the PR and between a28f875 and 6f9ed74.

📒 Files selected for processing (1)
  • internal/update/npm.go
📝 Walkthrough

Walkthrough

Modified the NPM package installation command to explicitly append the @latest tag to the package specification for both local and global install scenarios, changing from @localstack/lstk to @localstack/lstk@latest.

Changes

Cohort / File(s) Summary
NPM Install Update
internal/update/npm.go		 Added @latest version tag to the package specification in NPM install invocations for both local and global installation paths.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: fixing npm update to fetch the latest package version by adding @latest tag to the install command.
Description check ✅ Passed The description explains the problem (npm install could be a no-op) and the solution (using @latest tag), directly relating to the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch george/des-173
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

carole-lavillonniere
carole-lavillonniere approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@carole-lavillonniere carole-lavillonniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 👏

@gtsiolis
Copy link
Copy Markdown
Member Author

gtsiolis commented Mar 17, 2026

Thanks for taking a look, @carole-lavillonniere! 🌮

@gtsiolis gtsiolis merged commit 43d9c2e into main Mar 17, 2026
7 checks passed
@gtsiolis gtsiolis deleted the george/des-173 branch March 17, 2026 13:57
@gtsiolis gtsiolis mentioned this pull request Mar 24, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carole-lavillonniere carole-lavillonniere carole-lavillonniere approved these changes

@silv-io silv-io Awaiting requested review from silv-io silv-io is a code owner

@anisaoshafi anisaoshafi Awaiting requested review from anisaoshafi anisaoshafi is a code owner

Assignees

@gtsiolis gtsiolis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gtsiolis @carole-lavillonniere