Skip to content

Validate container port at config load time#120

Merged
gtsiolis merged 1 commit intomainfrom
george/add-port-validation
Mar 17, 2026
Merged

Validate container port at config load time#120
gtsiolis merged 1 commit intomainfrom
george/add-port-validation

Conversation

@gtsiolis
Copy link
Copy Markdown
Member

@gtsiolis gtsiolis commented Mar 17, 2026 •
edited
Loading

Ports like "abc" or "99999" previously passed through config loading silently and only failed at runtime.

This will check port is numeric and within 1–65535, etc.

Fix DES-171

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 17, 2026

Warning

Rate limit exceeded

@gtsiolis has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 44 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 9dacd2b7-3871-4707-a229-8a6844bee7ef

📥 Commits

Reviewing files that changed from the base of the PR and between 02634f1 and f67c7f6.

📒 Files selected for processing (3)
  • internal/config/config.go
  • internal/config/containers.go
  • internal/config/containers_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch george/add-port-validation
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

anisaoshafi
anisaoshafi approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@anisaoshafi anisaoshafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👏🏼

@gtsiolis gtsiolis self-assigned this Mar 17, 2026
@gtsiolis
Copy link
Copy Markdown
Member Author

gtsiolis commented Mar 17, 2026

Thanks for taking a look, @anisaoshafi! 🏀

@gtsiolis gtsiolis merged commit aa05700 into main Mar 17, 2026
8 checks passed
@gtsiolis gtsiolis deleted the george/add-port-validation branch March 17, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anisaoshafi anisaoshafi anisaoshafi approved these changes

@carole-lavillonniere carole-lavillonniere Awaiting requested review from carole-lavillonniere carole-lavillonniere is a code owner

@silv-io silv-io Awaiting requested review from silv-io silv-io is a code owner

Assignees

@gtsiolis gtsiolis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gtsiolis @anisaoshafi