Use checkmark for success message

gtsiolis · gtsiolis · commit fc18360847de · 2026-03-13T15:05:35.000+02:00
diff --git a/internal/output/plain_format.go b/internal/output/plain_format.go
@@ -42,9 +42,9 @@ func formatStatusLine(e ContainerStatusEvent) (string, bool) {
 		return "Waiting for LocalStack to be ready...", true
 	case "ready":
 		if e.Detail != "" {
-			return fmt.Sprintf("LocalStack ready (%s)", e.Detail), true
+			return fmt.Sprintf("%s LocalStack ready (%s)", SuccessMarker(), e.Detail), true
 		}
-		return "LocalStack ready", true
+		return SuccessMarker() + " LocalStack ready", true
 	default:
 		if e.Detail != "" {
 			return fmt.Sprintf("LocalStack: %s (%s)", e.Phase, e.Detail), true
@@ -112,7 +112,7 @@ func formatAuthEvent(e AuthEvent) string {
 func formatMessageEvent(e MessageEvent) string {
 	switch e.Severity {
 	case SeveritySuccess:
-		return "> Success: " + e.Text
+		return SuccessMarker() + " " + e.Text
 	case SeverityNote:
 		return "> Note: " + e.Text
 	case SeverityWarning:
diff --git a/internal/output/plain_format_test.go b/internal/output/plain_format_test.go
@@ -20,7 +20,7 @@ func TestFormatEventLine(t *testing.T) {
 		{
 			name:   "message event success",
 			event:  MessageEvent{Severity: SeveritySuccess, Text: "done"},
-			want:   "> Success: done",
+			want:   "\x1b[38;2;183;201;92m✔︎\x1b[0m done",
 			wantOK: true,
 		},
 		{
@@ -56,7 +56,7 @@ func TestFormatEventLine(t *testing.T) {
 		{
 			name:   "status ready with detail",
 			event:  ContainerStatusEvent{Phase: "ready", Container: "localstack-aws", Detail: "abc123"},
-			want:   "LocalStack ready (abc123)",
+			want:   "\x1b[38;2;183;201;92m✔︎\x1b[0m LocalStack ready (abc123)",
 			wantOK: true,
 		},
 		{
diff --git a/internal/output/plain_sink_test.go b/internal/output/plain_sink_test.go
@@ -59,12 +59,12 @@ func TestPlainSink_EmitsStatusEvent(t *testing.T) {
 		{
 			name:     "ready phase with detail",
 			event:    ContainerStatusEvent{Phase: "ready", Container: "localstack-aws", Detail: "abc123"},
-			expected: "LocalStack ready (abc123)\n",
+			expected: "\x1b[38;2;183;201;92m✔︎\x1b[0m LocalStack ready (abc123)\n",
 		},
 		{
 			name:     "ready phase without detail",
 			event:    ContainerStatusEvent{Phase: "ready", Container: "localstack-aws"},
-			expected: "LocalStack ready\n",
+			expected: "\x1b[38;2;183;201;92m✔︎\x1b[0m LocalStack ready\n",
 		},
 		{
 			name:     "unknown phase with detail",
diff --git a/internal/output/style.go b/internal/output/style.go
@@ -0,0 +1,13 @@
+package output
+
+import "fmt"
+
+const SuccessColorHex = "#B7C95C"
+
+func SuccessMarker() string {
+	return fmt.Sprintf("\x1b[38;2;183;201;92m%s\x1b[0m", SuccessMarkerText())
+}
+
+func SuccessMarkerText() string {
+	return "✔︎"
+}
diff --git a/internal/ui/app_test.go b/internal/ui/app_test.go
@@ -174,7 +174,7 @@ func TestAppMessageEventRendering(t *testing.T) {
 	if len(app.lines) != 1 {
 		t.Fatalf("expected 1 line, got %d", len(app.lines))
 	}
-	if !strings.Contains(app.lines[0].text, "Success:") || !strings.Contains(app.lines[0].text, "Done") {
+	if !strings.Contains(app.lines[0].text, "✔︎") || !strings.Contains(app.lines[0].text, "Done") {
 		t.Fatalf("expected rendered success message, got: %q", app.lines[0].text)
 	}
 }
diff --git a/internal/ui/components/message.go b/internal/ui/components/message.go
@@ -9,7 +9,7 @@ func RenderMessage(e output.MessageEvent) string {
 	prefix := styles.Secondary.Render("> ")
 	switch e.Severity {
 	case output.SeveritySuccess:
-		return prefix + styles.Success.Render("Success:") + " " + styles.Message.Render(e.Text)
+		return styles.Success.Render(output.SuccessMarkerText()) + " " + styles.Message.Render(e.Text)
 	case output.SeverityNote:
 		return prefix + styles.Note.Render("Note:") + " " + styles.Message.Render(e.Text)
 	case output.SeverityWarning:
diff --git a/internal/ui/styles/styles.go b/internal/ui/styles/styles.go
@@ -1,6 +1,9 @@
 package styles
 
-import "github.com/charmbracelet/lipgloss"
+import (
+	"github.com/charmbracelet/lipgloss"
+	"github.com/localstack/lstk/internal/output"
+)
 
 const (
 	NimboDarkColor  = "#3F51C7"
@@ -39,7 +42,7 @@ var (
 
 	// Message severity styles
 	Success = lipgloss.NewStyle().
-		Foreground(lipgloss.Color("42"))
+		Foreground(lipgloss.Color(output.SuccessColorHex))
 
 	Note = lipgloss.NewStyle().
 		Foreground(lipgloss.Color("33"))

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ func TestFormatEventLine(t *testing.T) {`
`20`	`20`	`{`
`21`	`21`	`name: "message event success",`
`22`	`22`	`event: MessageEvent{Severity: SeveritySuccess, Text: "done"},`
`23`		`- want: "> Success: done",`
	`23`	`+ want: "\x1b[38;2;183;201;92m✔︎\x1b[0m done",`
`24`	`24`	`wantOK: true,`
`25`	`25`	`},`
`26`	`26`	`{`
`@@ -56,7 +56,7 @@ func TestFormatEventLine(t *testing.T) {`
`56`	`56`	`{`
`57`	`57`	`name: "status ready with detail",`
`58`	`58`	`event: ContainerStatusEvent{Phase: "ready", Container: "localstack-aws", Detail: "abc123"},`
`59`		`- want: "LocalStack ready (abc123)",`
	`59`	`+ want: "\x1b[38;2;183;201;92m✔︎\x1b[0m LocalStack ready (abc123)",`
`60`	`60`	`wantOK: true,`
`61`	`61`	`},`
`62`	`62`	`{`
Original file line number	Diff line number	Diff line change
`@@ -59,12 +59,12 @@ func TestPlainSink_EmitsStatusEvent(t *testing.T) {`
`59`	`59`	`{`
`60`	`60`	`name: "ready phase with detail",`
`61`	`61`	`event: ContainerStatusEvent{Phase: "ready", Container: "localstack-aws", Detail: "abc123"},`
`62`		`- expected: "LocalStack ready (abc123)\n",`
	`62`	`+ expected: "\x1b[38;2;183;201;92m✔︎\x1b[0m LocalStack ready (abc123)\n",`
`63`	`63`	`},`
`64`	`64`	`{`
`65`	`65`	`name: "ready phase without detail",`
`66`	`66`	`event: ContainerStatusEvent{Phase: "ready", Container: "localstack-aws"},`
`67`		`- expected: "LocalStack ready\n",`
	`67`	`+ expected: "\x1b[38;2;183;201;92m✔︎\x1b[0m LocalStack ready\n",`
`68`	`68`	`},`
`69`	`69`	`{`
`70`	`70`	`name: "unknown phase with detail",`
Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,7 @@ func TestAppMessageEventRendering(t *testing.T) {`
`174`	`174`	`if len(app.lines) != 1 {`
`175`	`175`	`t.Fatalf("expected 1 line, got %d", len(app.lines))`
`176`	`176`	`}`
`177`		`- if !strings.Contains(app.lines[0].text, "Success:") \|\| !strings.Contains(app.lines[0].text, "Done") {`
	`177`	`+ if !strings.Contains(app.lines[0].text, "✔︎") \|\| !strings.Contains(app.lines[0].text, "Done") {`
`178`	`178`	`t.Fatalf("expected rendered success message, got: %q", app.lines[0].text)`
`179`	`179`	`}`
`180`	`180`	`}`