Warn unsupported multiple containers of the same type

anisaoshafi · anisaoshafi · commit 66879be20ca9 · 2026-03-10T18:47:06.000+01:00
diff --git a/internal/container/start.go b/internal/container/start.go
@@ -39,6 +39,10 @@ func Start(ctx context.Context, rt runtime.Runtime, sink output.Sink, platformCl
 		return fmt.Errorf("failed to get config: %w", err)
 	}
 
+	if hasDuplicateContainerTypes(cfg.Containers) {
+		output.EmitWarning(sink, "running multiple emulators of the same type is not supported yet")
+	}
+
 	containers := make([]runtime.ContainerConfig, len(cfg.Containers))
 	for i, c := range cfg.Containers {
 		image, err := c.Image()
@@ -247,3 +251,14 @@ func awaitStartup(ctx context.Context, rt runtime.Runtime, sink output.Sink, con
 		}
 	}
 }
+
+func hasDuplicateContainerTypes(containers []config.ContainerConfig) bool {
+	seen := make(map[config.EmulatorType]bool)
+	for _, c := range containers {
+		if seen[c.Type] {
+			return true
+		}
+		seen[c.Type] = true
+	}
+	return false
+}

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,10 @@ func Start(ctx context.Context, rt runtime.Runtime, sink output.Sink, platformCl`
`39`	`39`	`return fmt.Errorf("failed to get config: %w", err)`
`40`	`40`	`}`
`41`	`41`
	`42`	`+ if hasDuplicateContainerTypes(cfg.Containers) {`
	`43`	`+ output.EmitWarning(sink, "running multiple emulators of the same type is not supported yet")`
	`44`	`+ }`
	`45`	`+`
`42`	`46`	`containers := make([]runtime.ContainerConfig, len(cfg.Containers))`
`43`	`47`	`for i, c := range cfg.Containers {`
`44`	`48`	`image, err := c.Image()`
`@@ -247,3 +251,14 @@ func awaitStartup(ctx context.Context, rt runtime.Runtime, sink output.Sink, con`
`247`	`251`	`}`
`248`	`252`	`}`
`249`	`253`	`}`
	`254`	`+`
	`255`	`+func hasDuplicateContainerTypes(containers []config.ContainerConfig) bool {`
	`256`	`+ seen := make(map[config.EmulatorType]bool)`
	`257`	`+ for _, c := range containers {`
	`258`	`+ if seen[c.Type] {`
	`259`	`+ return true`
	`260`	`+ }`
	`261`	`+ seen[c.Type] = true`
	`262`	`+ }`
	`263`	`+ return false`
	`264`	`+}`