Remove raw ANSI color from non-TUI success marker

gtsiolis · gtsiolis · commit 5e1991c1bda9 · 2026-03-16T22:00:32.000+02:00
diff --git a/internal/output/style.go b/internal/output/style.go
@@ -1,13 +1,7 @@
 package output
 
-import "fmt"
-
 const SuccessColorHex = "#B7C95C"
 
-func SuccessMarker() string {
-	return fmt.Sprintf("\x1b[38;2;183;201;92m%s\x1b[0m", SuccessMarkerText())
-}
-
 func SuccessMarkerText() string {
 	return "✔︎"
 }
diff --git a/internal/ui/app.go b/internal/ui/app.go
@@ -182,6 +182,9 @@ func (a App) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 			a.pullProgress = a.pullProgress.Hide()
 		}
 		if line, ok := output.FormatEventLine(msg); ok {
+			if msg.Phase == "ready" {
+				line = strings.Replace(line, output.SuccessMarkerText(), styles.Success.Render(output.SuccessMarkerText()), 1)
+			}
 			a.lines = appendLine(a.lines, styledLine{text: line})
 		}
 		return a, nil
diff --git a/internal/ui/components/message.go b/internal/ui/components/message.go
@@ -42,7 +42,7 @@ func messagePrefix(e output.MessageEvent) (string, string) {
 	switch e.Severity {
 	case output.SeveritySuccess:
 		checkmark := output.SuccessMarkerText()
-		return "> " + checkmark, prefix + styles.Success.Render(checkmark)
+		return checkmark, styles.Success.Render(checkmark)
 	case output.SeverityNote:
 		return "> Note:", prefix + styles.Note.Render("Note:")
 	case output.SeverityWarning:

Original file line number	Diff line number	Diff line change
`@@ -182,6 +182,9 @@ func (a App) Update(msg tea.Msg) (tea.Model, tea.Cmd) {`
`182`	`182`	`a.pullProgress = a.pullProgress.Hide()`
`183`	`183`	`}`
`184`	`184`	`if line, ok := output.FormatEventLine(msg); ok {`
	`185`	`+ if msg.Phase == "ready" {`
	`186`	`+ line = strings.Replace(line, output.SuccessMarkerText(), styles.Success.Render(output.SuccessMarkerText()), 1)`
	`187`	`+ }`
`185`	`188`	`a.lines = appendLine(a.lines, styledLine{text: line})`
`186`	`189`	`}`
`187`	`190`	`return a, nil`