Migrate deprecated EmitLog calls to EmitInfo

silv-io · silv-io · commit 5836ababdd76 · 2026-02-25T17:45:04.000+01:00
diff --git a/internal/auth/auth.go b/internal/auth/auth.go
@@ -41,7 +41,7 @@ func (a *Auth) GetToken(ctx context.Context) (string, error) {
 		return "", fmt.Errorf("authentication required: set LOCALSTACK_AUTH_TOKEN or run in interactive mode")
 	}
 
-	output.EmitLog(a.sink, "No existing credentials found. Please log in:")
+	output.EmitInfo(a.sink, "No existing credentials found. Please log in:")
 	token, err := a.login.Login(ctx)
 	if err != nil {
 		output.EmitWarning(a.sink, "Authentication failed.")
@@ -52,7 +52,7 @@ func (a *Auth) GetToken(ctx context.Context) (string, error) {
 		output.EmitWarning(a.sink, fmt.Sprintf("could not store token in keyring: %v", err))
 	}
 
-	output.EmitLog(a.sink, "Login successful.")
+	output.EmitSuccess(a.sink, "Login successful.")
 	return token, nil
 }
 
diff --git a/internal/auth/login.go b/internal/auth/login.go
@@ -35,8 +35,8 @@ func (l *loginProvider) Login(ctx context.Context) (string, error) {
 	}
 
 	authURL := fmt.Sprintf("%s/auth/request/%s", getWebAppURL(), authReq.ID)
-	output.EmitLog(l.sink, fmt.Sprintf("Visit: %s", authURL))
-	output.EmitLog(l.sink, fmt.Sprintf("Verification code: %s", authReq.Code))
+	output.EmitInfo(l.sink, fmt.Sprintf("Visit: %s", authURL))
+	output.EmitInfo(l.sink, fmt.Sprintf("Verification code: %s", authReq.Code))
 
 	// Ask whether to open the browser; ENTER or Y accepts (default yes), N skips
 	browserCh := make(chan output.InputResponse, 1)
@@ -53,7 +53,7 @@ func (l *loginProvider) Login(ctx context.Context) (string, error) {
 		}
 		if resp.SelectedKey != "n" {
 			if err := browser.OpenURL(authURL); err != nil {
-				output.EmitLog(l.sink, fmt.Sprintf("Warning: Failed to open browser: %v", err))
+				output.EmitWarning(l.sink, fmt.Sprintf("Failed to open browser: %v", err))
 			}
 		}
 	case <-ctx.Done():
@@ -84,22 +84,22 @@ func getWebAppURL() string {
 }
 
 func (l *loginProvider) completeAuth(ctx context.Context, authReq *api.AuthRequest) (string, error) {
-	output.EmitLog(l.sink, "Checking if auth request is confirmed...")
+	output.EmitInfo(l.sink, "Checking if auth request is confirmed...")
 	confirmed, err := l.platformClient.CheckAuthRequestConfirmed(ctx, authReq.ID, authReq.ExchangeToken)
 	if err != nil {
 		return "", fmt.Errorf("failed to check auth request: %w", err)
 	}
 	if !confirmed {
 		return "", fmt.Errorf("auth request not confirmed - please complete the authentication in your browser")
 	}
-	output.EmitLog(l.sink, "Auth request confirmed, exchanging for token...")
+	output.EmitInfo(l.sink, "Auth request confirmed, exchanging for token...")
 
 	bearerToken, err := l.platformClient.ExchangeAuthRequest(ctx, authReq.ID, authReq.ExchangeToken)
 	if err != nil {
 		return "", fmt.Errorf("failed to exchange auth request: %w", err)
 	}
 
-	output.EmitLog(l.sink, "Fetching license token...")
+	output.EmitInfo(l.sink, "Fetching license token...")
 	licenseToken, err := l.platformClient.GetLicenseToken(ctx, bearerToken)
 	if err != nil {
 		return "", fmt.Errorf("failed to get license token: %w", err)
diff --git a/internal/container/start.go b/internal/container/start.go
@@ -139,7 +139,7 @@ func selectContainersToStart(ctx context.Context, rt runtime.Runtime, sink outpu
 			return nil, fmt.Errorf("failed to check container status: %w", err)
 		}
 		if running {
-			output.EmitLog(sink, fmt.Sprintf("%s is already running", c.Name))
+			output.EmitInfo(sink, fmt.Sprintf("%s is already running", c.Name))
 			continue
 		}
 		if err := ports.CheckAvailable(c.Port); err != nil {
diff --git a/internal/output/events.go b/internal/output/events.go
@@ -123,7 +123,6 @@ func EmitLog(sink Sink, message string) {
 	Emit(sink, MessageEvent{Severity: SeverityInfo, Text: message})
 }
 
-// Deprecated: Use EmitWarning with MessageEvent instead
 func EmitWarning(sink Sink, message string) {
 	Emit(sink, MessageEvent{Severity: SeverityWarning, Text: message})
 }
diff --git a/internal/ui/components/spinner_test.go b/internal/ui/components/spinner_test.go
@@ -48,7 +48,7 @@ func TestSpinner_Update(t *testing.T) {
 	s := NewSpinner()
 	s = s.Start("Loading")
 
-	s, cmd := s.Update(spinner.TickMsg{})
+	_, cmd := s.Update(spinner.TickMsg{})
 	if cmd == nil {
 		t.Fatal("expected non-nil command from spinner update")
 	}

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ func (a *Auth) GetToken(ctx context.Context) (string, error) {`
`41`	`41`	`return "", fmt.Errorf("authentication required: set LOCALSTACK_AUTH_TOKEN or run in interactive mode")`
`42`	`42`	`}`
`43`	`43`
`44`		`- output.EmitLog(a.sink, "No existing credentials found. Please log in:")`
	`44`	`+ output.EmitInfo(a.sink, "No existing credentials found. Please log in:")`
`45`	`45`	`token, err := a.login.Login(ctx)`
`46`	`46`	`if err != nil {`
`47`	`47`	`output.EmitWarning(a.sink, "Authentication failed.")`
`@@ -52,7 +52,7 @@ func (a *Auth) GetToken(ctx context.Context) (string, error) {`
`52`	`52`	`output.EmitWarning(a.sink, fmt.Sprintf("could not store token in keyring: %v", err))`
`53`	`53`	`}`
`54`	`54`
`55`		`- output.EmitLog(a.sink, "Login successful.")`
	`55`	`+ output.EmitSuccess(a.sink, "Login successful.")`
`56`	`56`	`return token, nil`
`57`	`57`	`}`
`58`	`58`
Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,8 @@ func (l *loginProvider) Login(ctx context.Context) (string, error) {`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`authURL := fmt.Sprintf("%s/auth/request/%s", getWebAppURL(), authReq.ID)`
`38`		`- output.EmitLog(l.sink, fmt.Sprintf("Visit: %s", authURL))`
`39`		`- output.EmitLog(l.sink, fmt.Sprintf("Verification code: %s", authReq.Code))`
	`38`	`+ output.EmitInfo(l.sink, fmt.Sprintf("Visit: %s", authURL))`
	`39`	`+ output.EmitInfo(l.sink, fmt.Sprintf("Verification code: %s", authReq.Code))`
`40`	`40`
`41`	`41`	`// Ask whether to open the browser; ENTER or Y accepts (default yes), N skips`
`42`	`42`	`browserCh := make(chan output.InputResponse, 1)`
`@@ -53,7 +53,7 @@ func (l *loginProvider) Login(ctx context.Context) (string, error) {`
`53`	`53`	`}`
`54`	`54`	`if resp.SelectedKey != "n" {`
`55`	`55`	`if err := browser.OpenURL(authURL); err != nil {`
`56`		`- output.EmitLog(l.sink, fmt.Sprintf("Warning: Failed to open browser: %v", err))`
	`56`	`+ output.EmitWarning(l.sink, fmt.Sprintf("Failed to open browser: %v", err))`
`57`	`57`	`}`
`58`	`58`	`}`
`59`	`59`	`case <-ctx.Done():`
`@@ -84,22 +84,22 @@ func getWebAppURL() string {`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`func (l loginProvider) completeAuth(ctx context.Context, authReq api.AuthRequest) (string, error) {`
`87`		`- output.EmitLog(l.sink, "Checking if auth request is confirmed...")`
	`87`	`+ output.EmitInfo(l.sink, "Checking if auth request is confirmed...")`
`88`	`88`	`confirmed, err := l.platformClient.CheckAuthRequestConfirmed(ctx, authReq.ID, authReq.ExchangeToken)`
`89`	`89`	`if err != nil {`
`90`	`90`	`return "", fmt.Errorf("failed to check auth request: %w", err)`
`91`	`91`	`}`
`92`	`92`	`if !confirmed {`
`93`	`93`	`return "", fmt.Errorf("auth request not confirmed - please complete the authentication in your browser")`
`94`	`94`	`}`
`95`		`- output.EmitLog(l.sink, "Auth request confirmed, exchanging for token...")`
	`95`	`+ output.EmitInfo(l.sink, "Auth request confirmed, exchanging for token...")`
`96`	`96`
`97`	`97`	`bearerToken, err := l.platformClient.ExchangeAuthRequest(ctx, authReq.ID, authReq.ExchangeToken)`
`98`	`98`	`if err != nil {`
`99`	`99`	`return "", fmt.Errorf("failed to exchange auth request: %w", err)`
`100`	`100`	`}`
`101`	`101`
`102`		`- output.EmitLog(l.sink, "Fetching license token...")`
	`102`	`+ output.EmitInfo(l.sink, "Fetching license token...")`
`103`	`103`	`licenseToken, err := l.platformClient.GetLicenseToken(ctx, bearerToken)`
`104`	`104`	`if err != nil {`
`105`	`105`	`return "", fmt.Errorf("failed to get license token: %w", err)`
Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ func selectContainersToStart(ctx context.Context, rt runtime.Runtime, sink outpu`
`139`	`139`	`return nil, fmt.Errorf("failed to check container status: %w", err)`
`140`	`140`	`}`
`141`	`141`	`if running {`
`142`		`- output.EmitLog(sink, fmt.Sprintf("%s is already running", c.Name))`
	`142`	`+ output.EmitInfo(sink, fmt.Sprintf("%s is already running", c.Name))`
`143`	`143`	`continue`
`144`	`144`	`}`
`145`	`145`	`if err := ports.CheckAvailable(c.Port); err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,6 @@ func EmitLog(sink Sink, message string) {`
`123`	`123`	`Emit(sink, MessageEvent{Severity: SeverityInfo, Text: message})`
`124`	`124`	`}`
`125`	`125`
`126`		`-// Deprecated: Use EmitWarning with MessageEvent instead`
`127`	`126`	`func EmitWarning(sink Sink, message string) {`
`128`	`127`	`Emit(sink, MessageEvent{Severity: SeverityWarning, Text: message})`
`129`	`128`	`}`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ func TestSpinner_Update(t *testing.T) {`
`48`	`48`	`s := NewSpinner()`
`49`	`49`	`s = s.Start("Loading")`
`50`	`50`
`51`		`- s, cmd := s.Update(spinner.TickMsg{})`
	`51`	`+ _, cmd := s.Update(spinner.TickMsg{})`
`52`	`52`	`if cmd == nil {`
`53`	`53`	`t.Fatal("expected non-nil command from spinner update")`
`54`	`54`	`}`