Skip to content

Commit 4187957

Browse files
address review comments
1 parent eaebd4b commit 4187957

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

internal/telemetry/client_test.go

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,17 @@ func TestTrack_SendsCorrectPayloadAndHeaders(t *testing.T) {
2424

2525
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
2626
body, err := io.ReadAll(r.Body)
27-
require.NoError(t, err)
27+
assert.NoError(t, err)
2828

2929
var req struct {
3030
Events []map[string]any `json:"events"`
3131
}
32-
require.NoError(t, json.Unmarshal(body, &req))
33-
require.Len(t, req.Events, 1)
32+
assert.NoError(t, json.Unmarshal(body, &req))
33+
assert.Len(t, req.Events, 1)
3434

35-
ch <- captured{event: req.Events[0], header: r.Header.Clone()}
35+
if len(req.Events) == 1 {
36+
ch <- captured{event: req.Events[0], header: r.Header.Clone()}
37+
}
3638
w.WriteHeader(http.StatusOK)
3739
}))
3840
defer srv.Close()
@@ -41,7 +43,12 @@ func TestTrack_SendsCorrectPayloadAndHeaders(t *testing.T) {
4143
c.Track("cli_cmd", map[string]any{"cmd": "lstk start", "params": []string{}})
4244
c.Flush()
4345

44-
got := <-ch
46+
var got captured
47+
select {
48+
case got = <-ch:
49+
default:
50+
t.Fatal("no telemetry event received")
51+
}
4552

4653
assert.Equal(t, "cli_cmd", got.event["name"])
4754

0 commit comments

Comments
 (0)