Skip to content

Conversation

@alexrashed
Copy link
Member

@alexrashed alexrashed commented Sep 17, 2025

Motivation

The terraform-init extension is using a package installer that is contained in localstack-core.
However, this installer was only used in tests which are about to be removed, hence we will also remove the obsolete installer (see localstack/localstack#13154).
This PR migrates the installer here such that the extension manages the installation of terraform itself (similar to tflocal).

Changes

  • Migrates the tflocal installer to a new packages module.
  • Migrates the terraform package installer from localstack-core to localstack-extension-terraform-init.

@alexrashed alexrashed requested a review from thrau September 17, 2025 07:15
@alexrashed alexrashed added the enhancement New feature or request label Sep 17, 2025
@alexrashed alexrashed assigned bentsku and unassigned thrau Sep 17, 2025
@alexrashed alexrashed requested review from bentsku and removed request for thrau September 17, 2025 11:59
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think this change makes sense, this extension being entirely focused on Terraform, it should contain the logic to interact with Terraform. Thanks for taking care this! 🚀

@alexrashed alexrashed merged commit bbc5d7f into main Sep 17, 2025
@alexrashed alexrashed deleted the migrate-terraform-package branch September 17, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants