Skip to content

Conversation

@dominikschubert
Copy link
Member

@dominikschubert dominikschubert commented Dec 19, 2023

Motivation

We've started seeing repeatable failures in CI due to a snapshot mismatch for tests/aws/services/cloudformation/resources/test_lambda.py::TestCfnLambdaIntegrations::test_cfn_lambda_dynamodb_source.

=================================== FAILURES ===================================
__________ TestCfnLambdaIntegrations.test_cfn_lambda_dynamodb_source ___________
>> match key: describe_table_result
	(+)  /Table/DeletionProtectionEnabled ( False )

My investigation pointed towards a new update of DynamoDB local as the culprit (AWS recently released a 2.2.0 version with support for Table delete protection)

Changes

  • Download DynamoDB Local artifact from maven instead of AWS so that we can pin the downloaded version to avoid PRs like this in the future and can upgrade in more controlled matter. (e.g. driven by issues detected by snapshot updates against AWS).
  • Add 2.1.0, 2.2.0 and a latest (previous default) to the package
  • Set default version to the new 2.2.0 version
  • Updated snapshot of affected test

TODO

  • dependencies are not bundled in the jar file, so we'd need to bundle them separately if we want to continue with this solution in the future

@dominikschubert dominikschubert self-assigned this Dec 19, 2023
@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Dec 19, 2023
@simonrw simonrw added this to the Playground milestone Jan 22, 2024
@viren-nadkarni
Copy link
Member

Superseded by #11064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants