Skip to content

Fix AWS parity for SQS list queues with empty response #9828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thrau merged 1 commit into from
Dec 11, 2023
Merged

Fix AWS parity for SQS list queues with empty response #9828

thrau merged 1 commit into from
Dec 11, 2023

Conversation

@joe4dev
Copy link
Member

@joe4dev joe4dev commented Dec 8, 2023

Motivation

Related discussion in #9710 (comment)

For empty lists, AWS often omits the field entirely, independent of the protocol. I noticed this behavior recently while parity testing different SDK versions (which use different protocols) in the Lambda multiruntime tests.
I moved my Notion testing page to the SQS service to demonstrate the behavior for the listQueues operation (see here).

This behavior is independent of the protocol (both query + json).

Changes

  • Add AWS-validated test scenario with queue prefix matching that returns an empty result
  • Omit the QueueUrls in the API response for empty results.

@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Dec 8, 2023
@joe4dev joe4dev self-assigned this Dec 8, 2023
@coveralls
Copy link

coveralls commented Dec 8, 2023

Coverage Status

coverage: 84.295% (+0.004%) from 84.291%
when pulling 6925b81 on fix-sqs-list-queues-empty-parity
into da9b863 on master.

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 11m 7s ⏱️
2 399 tests 2 171 ✔️ 228 💤 0 ❌
2 400 runs  2 171 ✔️ 229 💤 0 ❌

Results for commit 6925b81.

@joe4dev joe4dev marked this pull request as ready for review December 8, 2023 17:19
@joe4dev joe4dev requested review from baermat and thrau as code owners December 8, 2023 17:19
thrau
thrau approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find! LGTM

null/empty field handling always gets me

@thrau thrau merged commit 685a335 into master Dec 11, 2023
@thrau thrau deleted the fix-sqs-list-queues-empty-parity branch December 11, 2023 09:59
@bentsku bentsku mentioned this pull request Dec 11, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thrau thrau thrau approved these changes

@baermat baermat Awaiting requested review from baermat

Assignees

@joe4dev joe4dev

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joe4dev @coveralls @thrau