add support for AWS::DynamoDB::GlobalTable resource type #9790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinzon
added
the
semver: minor
pinzon
force-pushed
the
feat/dynamob-global-table-rp
branch
from
5df083f to
06f2ae0
Compare
pinzon
requested review from
dominikschubert,
giograno,
simonrw and
viren-nadkarni
as code owners
dominikschubert
requested changes
Dec 4, 2023
Member
dominikschubert
left a comment
dominikschubert
left a comment
There was a problem hiding this comment.
A few minor suggestions where we miss proper failure handling.
localstack/services/dynamodb/resource_providers/aws_dynamodb_globaltable.py
Outdated
Show resolved
Hide resolved
localstack/services/dynamodb/resource_providers/aws_dynamodb_globaltable.py
Outdated
Show resolved
Hide resolved
dominikschubert
changed the title
dominikschubert
approved these changes
Dec 7, 2023
Member
dominikschubert
left a comment
dominikschubert
left a comment
There was a problem hiding this comment.
LGTM, thanks for addressing the issues!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds suport for DynamoDB::GlobalTable resource type in Cloudformation. Requested in #4565
Changes
Testing