[SFN] Fix string lexing in Intrinsic Function arguments #9783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MEPalma
added
the
semver: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: #9771
The current lexer for the SFN v2 interpreter occasionally encounters difficulty accurately lexing string literals declared as arguments within intrinsic functions. This pull request (PR) resolves this issue within the lexer by implementing a non-greedy approach to token consumption between quotes. This involves defining safe code points that exclude the specified quote delimiters, and appropriately associating escaped character symbols with their intended counterparts (\n, \r, \t).
Changes
Relevant updates to the intrinsic function lexer. Escape characters replacement in intrinsic function preprocessor. Relevant tests.