pin global awscli install in Dockerfile #9767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
added
the
semver: patch
bentsku
force-pushed
the
pin-global-awscli
branch
from
76babc5 to
589d9ef
Compare
alexrashed
approved these changes
Nov 29, 2023
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Great catch! We should really try to avoid having two environments in the image, but unfortunately, that would be a breaking change.
We just need to make sure that we remove this pin with #9710.
3 tasks
dominikschubert
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should make sure the global awscli install is the same version as the one we have in our virtual environment.
Changes
Pin the
awscliversion to be the same as the one is installed. We should make sure to update it with the botocore update.