fix type hints incompatible with python < 3.10 in aws_stack #9765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viren-nadkarni
added
the
semver: patch
alexrashed
requested changes
Nov 29, 2023
localstack/utils/aws/aws_stack.py
Outdated
|
|
||
| def fix_account_id_in_arns( | ||
| response, replacement: str, colon_delimiter: str = ":", existing: str | list[str] = None | ||
| response, replacement: str, colon_delimiter: str = ":", existing: str | List[str] = None |
Member
There was a problem hiding this comment.
The type operator for union types (|) was introduced with 3.10, so this won't fix the issue I'm afraid...
Member
Author
There was a problem hiding this comment.
The CLI Tests / cli-tests (3.8) job seems to be passing but I've gone ahead and changed this in 5f755f2
alexrashed
changed the title
alexrashed
approved these changes
Nov 29, 2023
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Thanks for jumping on this! 🚀 🧹 💚
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use of subscriptable types broke CLI tests in for older Python version, specifically the cli-tests (3.8) job.
This PR makes use of backward-compatible type hints.