Skip to content

Conversation

@alexrashed
Copy link
Member

Motivation

Yesterday we unpinned botocore again (with #9667).
This PR avoids the latest release of botocore, which - again - reverts the SQS protocol back to query (with boto/botocore#3071).

Changes

  • Avoids the latest version of botocore again which switches the SQS protocol (once again) back to query.

Next Steps

It feels like this is a safety measure for now, but the next try will be there soon.
We already have a solution at hand which is pretty hacky, but would get better with #9710.
The next steps therefore should be:

  • Rebase this PR, finish the cleanup, and remove the pin.
  • Switch the special handling from query to json and internalize the json SQS spec instead of the query spec.
    • This would allow us to use the latest version of botocore, but also provide both protocols.
  • As soon as botocore switches this again, we have to switch again.

In the meantime we will start efforts to pin our dependencies and only do coordinated updates of botocore (coming in the next few weeks), such that these breaking changes can be handled in a coordinated manner.

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Nov 23, 2023
@alexrashed alexrashed added this to the 3.0.1 milestone Nov 23, 2023
@alexrashed alexrashed self-assigned this Nov 23, 2023
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Hope this stabilizes soon...

@alexrashed alexrashed merged commit 7abd7cb into master Nov 23, 2023
@alexrashed alexrashed deleted the pin-botocore-again branch November 23, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants