remove sqs-query from health endpoint #9709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrashed
added
the
semver: patch
bentsku
approved these changes
Nov 22, 2023
Contributor
bentsku
left a comment
bentsku
left a comment
There was a problem hiding this comment.
LGTM! thanks a lot for fixing this, which could be a bit weird for users. That will be a big search for all the "sqs-query" when removing the alias 😄
Member
Author
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR removes the service alias for SQS to support the old
queryprotocol from the health endpoint (because it's not its own AWS service, just an alias for an existing service used to distinguish between the routing and allow loading a separate spec).Changes
Explicitly removes
sqs-queryfrom the health endpoint as a temporary workaround (until the "service alias" has been removed again)./cc @Pive01