Skip to content

unpin botocore, update minimum version #9667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexrashed merged 1 commit into from
Nov 22, 2023
Merged

unpin botocore, update minimum version #9667

alexrashed merged 1 commit into from
Nov 22, 2023

Conversation

@alexrashed
Copy link
Member

@alexrashed alexrashed commented Nov 17, 2023 •
edited
Loading

Motivation

With 815d6c7 we pinned botocore to version 1.31.85 to prevent incompatibilities with moto.
These issues were fixed in getmoto/moto#7030.
This PR will coordinate the update of botocore to the newest version, once we have the moto fix in, which might be addressed in #9624.

Changes

  • Remove the pin on botocore and update the minimum version.

Testing

  • We have lots of tests in place and botocore used basically everywhere. If we're green, we're fine. :)

TODO

  • Make sure the moto fix is available / wait for Bump moto-ext to 4.2.9.post2 #9624.
  • Rebase this PR on master after the upgrade of moto.
  • Make sure the test are green afterwards.
    • Also tested integration with Pro. 💚

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Nov 17, 2023
@alexrashed alexrashed self-assigned this Nov 17, 2023
@github-actions
Copy link

github-actions bot commented Nov 17, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 6m 42s ⏱️ + 1m 40s
2 330 tests ±0  2 030 ✔️ ±0  300 💤 ±0  0 ❌ ±0 
2 331 runs  ±0  2 030 ✔️ ±0  301 💤 ±0  0 ❌ ±0 

Results for commit 90aab34. ± Comparison against base commit 33b8e3f.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed force-pushed the upgrade-botocore-1-32 branch from d981552 to 90aab34 Compare November 22, 2023 07:51
@alexrashed alexrashed added this to the 3.0.1 milestone Nov 22, 2023
@alexrashed alexrashed marked this pull request as ready for review November 22, 2023 10:04
viren-nadkarni
viren-nadkarni approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

you might want to mention the -ext CI run for info.

@alexrashed alexrashed merged commit 4399dbe into master Nov 22, 2023
@alexrashed alexrashed deleted the upgrade-botocore-1-32 branch November 22, 2023 10:47
This was referenced Nov 23, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viren-nadkarni viren-nadkarni viren-nadkarni approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@dfangl dfangl Awaiting requested review from dfangl

Assignees

@alexrashed alexrashed

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

3.0.1

Development

Successfully merging this pull request may close these issues.

2 participants

@alexrashed @viren-nadkarni