add cw tests for lambda Invocations and Errors metrics #9653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffyP
added
the
semver: patch
steffyP
changed the title
steffyP
force-pushed
the
lambda-metric-reporting
branch
from
8316dd2 to
9fbef24
Compare
bentsku
approved these changes
Nov 20, 2023
Contributor
bentsku
left a comment
bentsku
left a comment
There was a problem hiding this comment.
LGTM! Nice tests, clean and fast 🚀 thanks a lot for adding those, will make it easier to implement the fix 👍
bentsku
reviewed
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While testing the pro-samples we found that lambda is not reporting the
Errorsmetrics anymore.The metric should be reported when a lambda invocation fails.
We didn't have integration tests for lambda metrics yet, so I added those now.
/cc @joe4dev
Changes
test_lambda_invoke_errorfor LS as it is currently not working -> this should be fixed 🙂