Skip to content

Bump moto-ext to 4.2.9.post2 #9624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
viren-nadkarni merged 8 commits into from
Nov 22, 2023
Merged

Bump moto-ext to 4.2.9.post2 #9624

viren-nadkarni merged 8 commits into from
Nov 22, 2023

Conversation

@viren-nadkarni
Copy link
Member

@viren-nadkarni viren-nadkarni commented Nov 14, 2023 •
edited
Loading

@viren-nadkarni viren-nadkarni self-assigned this Nov 14, 2023
@viren-nadkarni viren-nadkarni added the semver: patch Non-breaking changes which can be included in patch releases label Nov 14, 2023
@viren-nadkarni viren-nadkarni force-pushed the bump-moto-ext branch 2 times, most recently from c4f9ff7 to 5292c99 Compare November 14, 2023 10:46
@viren-nadkarni viren-nadkarni added this to the 3.0 milestone Nov 14, 2023
@coveralls
Copy link

coveralls commented Nov 15, 2023 •
edited
Loading

Coverage Status

coverage: 84.001%. remained the same
when pulling ccaedf2 on bump-moto-ext
into f7890b2 on master.

@github-actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files         2 suites   1h 5m 40s ⏱️
2 330 tests 2 030 ✔️ 300 💤 0 ❌
2 331 runs  2 030 ✔️ 301 💤 0 ❌

Results for commit ccaedf2.

♻️ This comment has been updated with latest results.

@viren-nadkarni viren-nadkarni marked this pull request as ready for review November 15, 2023 08:17
bentsku
bentsku approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the S3 part!

alexrashed
alexrashed reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are looking good to me! But please make sure to get a green ext it before merging, even if it was a flake (please rerun, or make sure this is fixed first).

@viren-nadkarni viren-nadkarni modified the milestones: 3.0, Playground Nov 15, 2023
@alexrashed
Copy link
Member

alexrashed commented Nov 17, 2023

It would be great if we could get the fix for using new botocore versions into the next moto upgrade: getmoto/moto#7030
This would allow us to unpin botocore again, which we had to do with 815d6c7 :)

@alexrashed alexrashed mentioned this pull request Nov 17, 2023
Merged
3 tasks
@viren-nadkarni viren-nadkarni changed the title Bump moto-ext to 4.2.8.post1 Bump moto-ext to 4.2.9.post1 Nov 20, 2023
@steffyP
Copy link
Member

steffyP commented Nov 20, 2023

FYI: this change in moto will break instance creation for docdb + neptune

@viren-nadkarni
Copy link
Member Author

viren-nadkarni commented Nov 21, 2023

Thanks for the tip @steffyP. This checks out with failures in the -ext CI:

botocore.exceptions.ClientError: An error occurred (InvalidParameterValue) when calling the CreateDBInstance operation: Value neptune for parameter Engine is invalid. Reason: engine neptune not supported

I've created a patch in moto-ext localstack/moto#72 and will release it as 4.2.9.post2

@viren-nadkarni viren-nadkarni changed the title Bump moto-ext to 4.2.9.post1 Bump moto-ext to 4.2.9.post2 Nov 21, 2023
@alexrashed alexrashed removed this from the Playground milestone Nov 21, 2023
@alexrashed alexrashed modified the milestones: 3.1, 3.0.1 Nov 21, 2023
@viren-nadkarni viren-nadkarni merged commit 33b8e3f into master Nov 22, 2023
@viren-nadkarni viren-nadkarni deleted the bump-moto-ext branch November 22, 2023 07:50
@alexrashed alexrashed mentioned this pull request Nov 23, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexrashed alexrashed alexrashed left review comments

@bblommers bblommers bblommers left review comments

@bentsku bentsku bentsku approved these changes

@macnev2013 macnev2013 Awaiting requested review from macnev2013

Assignees

@viren-nadkarni viren-nadkarni

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

3.0.1

Development

Successfully merging this pull request may close these issues.

6 participants

@viren-nadkarni @coveralls @alexrashed @steffyP @bblommers @bentsku