Skip to content

Conversation

@alexrashed
Copy link
Member

Motivation

Currently, some GitHub workflows which are automatically triggered when a PR is created are failing due to the missing access to certain secrets
This PR should fix these issues such that workflow executions triggered by PRs coming from community forks can get fully green (after they have been approved by a contributor).
/cc @joe4dev

Changes

Testing

  • These changes are somewhat hard to test, since they need to be merged to the default branch before they can be properly tested if the execution works for forks now.
  • Once this PR is merged, we can evaluate if the pipelines are now working for community raised fork-PRs.

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Oct 18, 2023
@alexrashed alexrashed self-assigned this Oct 18, 2023
@coveralls
Copy link

Coverage Status

coverage: 82.992% (-0.006%) from 82.998% when pulling 5e9abcd on fix-fork-pipeline-builds into 13e48bb on master.

@alexrashed alexrashed added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases semver: major Breaking changes which can be included in a major release only and removed semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases semver: major Breaking changes which can be included in a major release only labels Oct 18, 2023
@github-actions
Copy link

LocalStack Community integration with Pro

       2 files         2 suites   1h 14m 22s ⏱️
2 257 tests 1 753 ✔️ 504 💤 0
2 258 runs  1 753 ✔️ 505 💤 0

Results for commit 5e9abcd.

@alexrashed alexrashed requested a review from joe4dev October 18, 2023 14:49
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

@alexrashed alexrashed merged commit beb93d4 into master Oct 19, 2023
@alexrashed alexrashed deleted the fix-fork-pipeline-builds branch October 19, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants