Fix missing implementation of CloudFormation EC2 UserData #8957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe4dev
added
the
semver: patch
joe4dev
force-pushed
the
fix-cf-ec2-user-data
branch
from
8b780f0 to
a4390ce
Compare
viren-nadkarni
requested changes
Aug 23, 2023
joe4dev
force-pushed
the
fix-cf-ec2-user-data
branch
from
390d16d to
96e4c8e
Compare
viren-nadkarni
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support issue with CDK stack where
UserDatais not applied to freshly launched EC2 instances.UserDataitself is implemented and works in EC2.Changes
Add the missing CloudFormation implementation for the
UserDataproperty. It requires a callback to decode the base64-encoded field.Minor refactoring of verbose current folder implementation (initially started with EC2 test but I noticed that is better covered in a scenario test).
Testing
Tested through custom CDK stack and support sample. An EC2 scenario test is partially drafted for localstack-ext (follow up in separate PR).