Skip to content

Conversation

@etspaceman
Copy link
Contributor

See

https://github.com/etspaceman/kinesis-mock/releases/tag/v0.4.4

and

https://github.com/etspaceman/kinesis-mock/releases/tag/v0.4.3

Notice that these releases introduce some interesting new items:

  • http2 support
  • Fix for persistence path

I have not updated anything outside of the version. But I'd be happy to have some guidance to update any related items here.

Motivation

Bump kinesis-mock

Changes

Updates kinesis-mock to 0.4.4

@thrau thrau added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Aug 15, 2023
@alexrashed alexrashed self-requested a review October 18, 2023 10:46
@alexrashed alexrashed assigned alexrashed and unassigned alexrashed Oct 18, 2023
@alexrashed alexrashed added this to the 3.0 milestone Oct 18, 2023
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @etspaceman!
I'm really sorry I overlooked this PR for so long. I really appreciate that you proactively update kinesis-mock.
I just rebased this PR and will merge it as soon as the tests are 💚! 🚀
Again, sorry for the delay!
Ps.: Won't happen in the future, I'm adding myself as a codeowner such that I am selected as reviewer automatically in #9379.

See

https://github.com/etspaceman/kinesis-mock/releases/tag/v0.4.4

and

https://github.com/etspaceman/kinesis-mock/releases/tag/v0.4.3

Notice that these releases introduce some interesting new items:

- http2 support
- Fix for persistence path

I have not updated anything outside of the version. But I'd be happy to have some guidance to update any related items here.
@alexrashed
Copy link
Member

The CircleCI pipeline integration seems a bit off due to the pytest split distribution not finding lots of the test timings.
I'll move forward with the merge and take a close look on the pipeline execution on master.
Thanks again for the contribution and for continuously and pro-actively upgrading kinesis-mock! 🚀 🎖️

@alexrashed alexrashed merged commit 1c396c8 into localstack:master Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants