Skip to content

Conversation

@rahulmlokurte
Copy link
Contributor

Issue: #8232

@rahulmlokurte rahulmlokurte requested a review from thrau as a code owner May 1, 2023 13:03
Copy link
Contributor

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@localstack-bot
Copy link
Contributor

localstack-bot commented May 1, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@rahulmlokurte
Copy link
Contributor Author

rahulmlokurte commented May 1, 2023

I have read the CLA Document and I hereby sign the CLA

Remove extra line
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @rahulmlokurte, thanks for the contribution! looks like a useful feature.

i have a couple of comments that we could address before merging. generally i think the approach with reading the entire log stream and then filtering after we've loaded everything into memory could be improved by passing the lines argument down to the actual docker invocations. to that end we'd have to modify get_container_logs and stream_container_logs of the docker client. but we can do that another time.

cc @dfangl

@alexrashed alexrashed requested a review from thrau May 4, 2023 07:13
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the contribution @rahulmlokurte, and welcome to the list of contributors :-)

@thrau thrau merged commit 42f62d3 into localstack:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants