-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Display a specified number of log lines on console based on tail option #8233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
localstack-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Remove extra line
thrau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @rahulmlokurte, thanks for the contribution! looks like a useful feature.
i have a couple of comments that we could address before merging. generally i think the approach with reading the entire log stream and then filtering after we've loaded everything into memory could be improved by passing the lines argument down to the actual docker invocations. to that end we'd have to modify get_container_logs and stream_container_logs of the docker client. but we can do that another time.
cc @dfangl
thrau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for the contribution @rahulmlokurte, and welcome to the list of contributors :-)
Issue: #8232