Update Kinesis Mock to 0.3.10 #7748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
etspaceman
changed the title
alexrashed
approved these changes
Feb 28, 2023
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Thanks a lot, @etspaceman, for proactively upgrading kinesis-mock (and of course thanks a lot for maintaining this great open-source library)!
It seems like the snapshot tests are not failing, which indicates that the issues with 0.3.5 (#7639) have successfully been resolved.
Contributor
Author
|
Hah, they are resolved because I reverted those changes back. Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See bugfix in https://github.com/etspaceman/kinesis-mock/releases/tag/0.3.7 and https://github.com/etspaceman/kinesis-mock/releases/tag/0.3.9