-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Update Kinesis Mock to 0.3.0 #7346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thrau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Eric @etspaceman! Great to see another kinesis-mock release :-)
Just one minor change necessary for the merge.
localstack/config.py
Outdated
|
|
||
| # limit in which to kinesis-mock will start throwing exceptions | ||
| KINESIS_ON_DEMAND_STREAM_COUNT_LIMIT = os.environ.get( | ||
| "KINESIS_ON_DEMAND_STREAM_COUNT_LIMIT", "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the CLI to pass through the env var correctly to the container, it needs to be whitelisted in the CONFIG_ENV_VARS further down in config.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
fe6c553 to
00ab949
Compare
thrau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
See https://github.com/etspaceman/kinesis-mock/releases/tag/0.3.0
This adds the UpdateStreamMode API, as well as updates to a few other request/response bodies with information from the stream mode.
Also see https://docs.aws.amazon.com/kinesis/latest/APIReference/API_UpdateStreamMode.html