Skip to content

Add integration test for SQS FIFO event source order/parallelism #7037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thrau merged 1 commit into from
Jan 3, 2024
Merged

Add integration test for SQS FIFO event source order/parallelism #7037

thrau merged 1 commit into from
Jan 3, 2024

Conversation

@dominikschubert
Copy link
Member

@dominikschubert dominikschubert commented Oct 17, 2022

Adds an integration test covering #7036

@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests October 17, 2022 22:24 Inactive
@github-actions
Copy link

github-actions bot commented Oct 17, 2022

LocalStack integration with Pro

       1 files   -     2         1 suites   - 2   48m 31s ⏱️ - 32m 49s
1 395 tests  -   15  1 201 ✔️  -   26  193 💤 +  10  1 ❌ +1 
1 395 runs   - 613  1 201 ✔️  - 392  193 💤  - 222  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 9250f1c. ± Comparison against base commit e20e898.

@dominikschubert dominikschubert mentioned this pull request May 6, 2023
Merged
@thrau thrau force-pushed the test_sqs-fifo-source-order branch from 9250f1c to d0314e1 Compare May 10, 2023 00:45
@thrau thrau added the semver: patch Non-breaking changes which can be included in patch releases label May 10, 2023
@github-actions
Copy link

github-actions bot commented May 10, 2023 •
edited
Loading

LocalStack Community integration with Pro

    2 files      2 suites   1h 16m 30s ⏱️
2 430 tests 2 204 ✅ 226 💤 0 ❌
2 431 runs  2 204 ✅ 227 💤 0 ❌

Results for commit 7877dd3.

♻️ This comment has been updated with latest results.

@dominikschubert dominikschubert modified the milestones: 2.2, 2.3 Jul 12, 2023
@alexrashed alexrashed modified the milestones: 2.3, 3.0 Sep 28, 2023
@dominikschubert dominikschubert modified the milestones: 3.0, 3.1 Nov 14, 2023
@thrau thrau force-pushed the test_sqs-fifo-source-order branch from d0314e1 to c477616 Compare January 3, 2024 01:00
@thrau thrau mentioned this pull request Jan 3, 2024
Merged
@thrau
Copy link
Member

thrau commented Jan 3, 2024 •
edited
Loading

I updated the test, also ran the test against #9975 which now works

@thrau thrau force-pushed the test_sqs-fifo-source-order branch from c477616 to 7877dd3 Compare January 3, 2024 16:15
@coveralls
Copy link

coveralls commented Jan 3, 2024

Coverage Status

coverage: 84.019% (+0.002%) from 84.017%
when pulling 7877dd3 on test_sqs-fifo-source-order
into d501573 on master.

@thrau thrau marked this pull request as ready for review January 3, 2024 17:09
@thrau thrau requested review from dfangl and joe4dev as code owners January 3, 2024 17:09
thrau
thrau approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a great test, thanks for adding it @dominikschubert! i renamed the test and made some slight improvements. it works with the latest version of localstack.

@thrau thrau merged commit 7548ba6 into master Jan 3, 2024
@thrau thrau deleted the test_sqs-fifo-source-order branch January 3, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thrau thrau thrau approved these changes

@joe4dev joe4dev Awaiting requested review from joe4dev

@dfangl dfangl Awaiting requested review from dfangl

Assignees

No one assigned

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

3.1

Development

Successfully merging this pull request may close these issues.

5 participants

@dominikschubert @thrau @coveralls @alexrashed